Hi @yurishkuro,
Kindly review the PR now.

• the output is coming correct testing the endpoint

$ curl "http://localhost:5778/?service=x"
{"strategyType":0,"probabilisticSampling":{"samplingRate":0.001}}%

• I have updated the base main branch
• no other changes were suggested in logic, hence rest code is same

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (c7e0b78) to head (e7003d9).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main    #6431      +/-   ##
==========================================
+ Coverage   96.25%   96.27%   +0.02%     
==========================================
  Files         372      372              
  Lines       21276    21280       +4     
==========================================
+ Hits        20479    20488       +9     
+ Misses        609      605       -4     
+ Partials      188      187       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

$ docker run -p 5778:5778 jaegertracing/jaeger:2.1.0

$ curl "http://localhost:5778/?service=x"
{"strategyType":0,"probabilisticSampling":{"samplingRate":1}}%

The current default behavior is to return probability 1.0, not 0.001.

There is a hardcoded constant defaultSamplingProbability = 0.001, but we don't want to change it because jaeger-v1 should still be using that, so we need to make that value configurable in the static/provider

make sure to pull from remote branch before you continue work, to pick up the changes I made

Okay. So the initial issue regarding the dependancy of sampling-strategies.json file in all-in-one.yaml is resolved right? This is a new issue which needs to be solved?
To make SamplingRate configurable in static/provider, keeping defaultSamplingProbability const?
If yes, then I plan on implementing this by creating a factor (with default value 1000), which I will multiply defaultSamplingProbability with when returning SamplingRate. Am I on the right track?

The original issue is not resolved since these changes return different results from what v2.1.0 Jaeger container returns.

There is no need for any multiplier, the default probability should be made parameterizable via the provider API so that we can pass it from jaeger-v2 sampling extension (see #6441 for the pattern).

@yurishkuro Please have a look once now.

• A parameter for DefaultSamplingProbability has been created which can be filled using a flag, or using the yaml file input default_sampling_probability.
• A flag called "sampling.stategies-default-sampling-probability" has been created for the same
• If no input is given for DefaultSamplingProbability, it defaults to "defaultDefaultSamplingProbability" = 0.001. (which was originally used)
• DefaultSamplingProbability has been given value 0.001 in all-in-one.yaml (to give the default value as before)
• In all the tests given in the provider_test.go file, initially they used defaultSamplingProbability = 0.001. Since now this parameterized, I have used the value of defaultDefaultSamplingProbability = 0.001 instead now to keep the default behavior.
• Since no changes have been made to the original defaultSamplingProbability variable, the output still comes as follows:

 curl "http://localhost:5778/?service=x"
{"strategyType":0,"probabilisticSampling":{"samplingRate":0.001}}%  

Instead of

{"strategyType":0,"probabilisticSampling":{"samplingRate":1}}%  

whch you wanted. I wanted to confirm what change I have to do to set this.

@yurishkuro I have made the changes. Please have a look.
Also, I found that defaultSamplingProbability was not being used anywhere, except in the provider tests(which I replaced with DefaultDefaultSamplingProbability,as you can see. So I removed it.

please ensure all commits a signed.

@yurishkuro done .... some old commits were missing the signoff